Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored function names in msa.R | networks_domarch.R | networks_gencontext.R #101

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Refactored function names in msa.R | networks_domarch.R | networks_gencontext.R #101

merged 5 commits into from
Oct 22, 2024

Conversation

teddyCodex
Copy link
Collaborator

Description

Refactored specified function names in multiple files based on issue #7

R/msa.R

Original Modified User Facing
msa_pdf createMSA_PDF ✅
generate_msa createMSA_Kalign ✅

R/networks_domarch.R

Original Modified User Facing
domain_network createDomainNetwork ✅
BinaryDomainNetwork createBinaryDomainNetwork ✅

R/networks_gencontext.R

Original Modified User Facing
gc_undirected_network createUndirectedDomainNetwork ✅
GenContextNetwork createGenomicContextNetwork ✅

Fixes issue #49

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@teddyCodex teddyCodex requested a review from the-mayer October 14, 2024 18:10
@jananiravi jananiravi added outreachy for outreachy interns documentation Improvements or additions to documentation, incl. R docstring/roxygen2 labels Oct 20, 2024
@the-mayer the-mayer self-assigned this Oct 22, 2024
@the-mayer the-mayer linked an issue Oct 22, 2024 that may be closed by this pull request
Replace the function names in the listed files #49
Closed
the-mayer
the-mayer approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@the-mayer the-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sending to main!

@the-mayer the-mayer merged commit 7613887 into JRaviLab:main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mayer the-mayer the-mayer approved these changes

Assignees

@the-mayer the-mayer

Labels
documentation Improvements or additions to documentation, incl. R docstring/roxygen2 outreachy for outreachy interns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the function names in the listed files
3 participants
@teddyCodex @the-mayer @jananiravi